Suggestions to clarify pyArgus code

1

Hello, I would like to suggest you a few improvements to pyArgus.

In antennaArrayPattern.py, line 67, array aligment is said to be a 2D array. In directionEstimation.py, line 778, is said to be a 1D array. In beamform.py, several points, it is unclear. I guess that in beamform.py it should be a 1D array. If I have understood the right way, beamform.py is ready to use with ULA only.

I would use always the same format, and improve beamform.py to use UCA too, if possible.

I would add two more functions: gen_uca_array_aligment and gen_ula_array_aligment. This way the user would not need to know array_aligment format.

In beamform.py it is not clear if the author of the algorithm is Goadar or Godara, there is a typo in the function name or in the comments.

Thank you.
Ger EA4GJA

2

Thanks. Suggestions on PyArgus are best directed to the owner of the library itself. You could probably raise it as an issue on GitHub GitHub - petotamas/pyArgus: Antenna array signal processing library implemented in python

3

Ok, thank you. I will do as you said.